Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for opaque stream sources #3001

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Better error for opaque stream sources #3001

merged 1 commit into from
Dec 14, 2021

Conversation

jeffposnick
Copy link
Contributor

R: @tropicadri

Fixes #2998

It's not possible to mix an opaque response in with other non-opaque streaming sources in workbox-streams. Previously, this would lead to an ambiguous runtime exception. This PR adds some specific detection for it and throws a more meaningful error.

@tropicadri tropicadri merged commit 61d54d7 into v6 Dec 14, 2021
@jeffposnick jeffposnick deleted the opaque-stream-source branch February 23, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workbox-streams does not handle opaque responses properly
2 participants